Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 724843002: Rewrite, document, and test qualifiedNamesIn. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Rewrite, document, and test qualifiedNamesIn. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41771

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merged with r41770. #

Patch Set 3 : Rebased on r41770. #

Patch Set 4 : Address Johnni's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -27 lines) Patch
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 3 6 chunks +58 lines, -27 lines 0 comments Download
A dart/tests/try/poi/qualified_names_test.dart View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
6 years, 1 month ago (2014-11-13 16:52:35 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/724843002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/724843002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode686 dart/pkg/dart2js_incremental/lib/library_updater.dart:686: /// fourth identifier). I guess the reason for ...
6 years, 1 month ago (2014-11-14 10:33:36 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/724843002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/724843002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode686 dart/pkg/dart2js_incremental/lib/library_updater.dart:686: /// fourth identifier). On 2014/11/14 10:33:35, ...
6 years, 1 month ago (2014-11-17 10:39:47 UTC) #4
ahe
Committed patchset #4 (id:60001) manually as 41771 (presubmit successful).
6 years, 1 month ago (2014-11-17 10:40:28 UTC) #5
Johnni Winther
6 years, 1 month ago (2014-11-19 12:39:15 UTC) #6
Message was sent while issue was closed. 
Still LGTM

Powered by Google App Engine
This is Rietveld 408576698