Issue 7248006: Revert 3899 because it tanked V8 benchmark suite. We need an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7248006: Revert 3899 because it tanked V8 benchmark suite. We need an (Closed)

Created:
9 years, 6 months ago by Erik Corry

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Revert 3899 because it tanked V8 benchmark suite. We need an approach that resizes the store buffer according to the heap size. Committed: http://code.google.com/p/v8/source/detail?r=8401

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -90 lines)			Patch
M	src/heap.h	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	src/store-buffer.h	View	4 chunks	+7 lines, -32 lines	0 comments	Download
M	src/store-buffer.cc	View	9 chunks	+17 lines, -56 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 6 months ago (2011-06-23 14:50:16 UTC) #2

LGTM

http://codereview.chromium.org/7248006/diff/1/src/heap.h
File src/heap.h (left):

http://codereview.chromium.org/7248006/diff/1/src/heap.h#oldcode897
src/heap.h:897: if (FLAG_trace_gc_verbose) {
why revert this?

Expand Messages | Collapse Messages