Issue 724753002: Fix debugger with GL to work with non-default locale

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724753002: Fix debugger with GL to work with non-default locale (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen

Modified:
6 years, 1 month ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@no-sierpinsky-profiles

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix debugger with GL to work with non-default locale QApplication forces the process to use the C locale system on "Unix/Linux" according to the docs. The float numbers in GL shaders will be printed with printf. These will be formatted with comma in certain locales, like LC_NUMERIC=fi_FI.UTF-8. Force the NC_NUMERIC=C before running the QApplication. Committed: https://skia.googlesource.com/skia/+/6438f9aca75ae5a92044458fdc20040544e02709

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	debugger/debuggermain.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724753002/1

6 years, 1 month ago (2014-11-13 12:58:42 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 13:13:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6438f9aca75ae5a92044458fdc20040544e02709

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages