Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 724483002: Move painting code from RenderTableCell to TableCellPainter. (Closed)

Created:
6 years, 1 month ago by chrishtr
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderTableCell to TableCellPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185329

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -233 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/paint/TableCellPainter.h View 1 chunk +40 lines, -0 lines 0 comments Download
A Source/core/paint/TableCellPainter.cpp View 1 2 1 chunk +254 lines, -0 lines 0 comments Download
M Source/core/paint/TableRowPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/TableSectionPainter.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 4 chunks +4 lines, -218 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chrishtr
6 years, 1 month ago (2014-11-12 21:46:59 UTC) #2
chrishtr
Ping?
6 years, 1 month ago (2014-11-13 20:52:29 UTC) #4
leviw_travelin_and_unemployed
You've got a handful of truly epic line lengths in there that I'd give some ...
6 years, 1 month ago (2014-11-13 21:05:52 UTC) #5
chrishtr
https://codereview.chromium.org/724483002/diff/20001/Source/core/paint/TableCellPainter.cpp File Source/core/paint/TableCellPainter.cpp (right): https://codereview.chromium.org/724483002/diff/20001/Source/core/paint/TableCellPainter.cpp#newcode19 Source/core/paint/TableCellPainter.cpp:19: return styleForCellFlow->isLeftToRightDirection() ? m_renderTableCell.section()->cachedCollapsedBorder(&m_renderTableCell, CBSStart) : m_renderTableCell.section()->cachedCollapsedBorder(&m_renderTableCell, CBSEnd); On ...
6 years, 1 month ago (2014-11-13 21:31:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724483002/40001
6 years, 1 month ago (2014-11-13 21:44:48 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:06:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185329

Powered by Google App Engine
This is Rietveld 408576698