Issue 724133004: Remove arguments arity check in mjsunit because it vastly slows down the tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724133004: Remove arguments arity check in mjsunit because it vastly slows down the tests. (Closed)

Created:
6 years, 1 month ago by titzer

Modified:
6 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove arguments arity check in mjsunit because it vastly slows down the tests. R=mstarzinger@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/3bcea483a75b8c75f68a286ff191c662055726f2

Patch Set 2 : Remove. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	test/mjsunit/mjsunit.js	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://codereview.chromium.org/724133004/diff/1/test/mjsunit/mjsunit.js File test/mjsunit/mjsunit.js (right): https://codereview.chromium.org/724133004/diff/1/test/mjsunit/mjsunit.js#newcode242 test/mjsunit/mjsunit.js:242: // checkArity(arguments, 2, "assertSame"); So maybe instead of commenting ...

6 years, 1 month ago (2014-11-14 10:21:23 UTC) #2

titzer

On 2014/11/14 10:21:23, Michael Starzinger wrote: > https://codereview.chromium.org/724133004/diff/1/test/mjsunit/mjsunit.js > File test/mjsunit/mjsunit.js (right): > > https://codereview.chromium.org/724133004/diff/1/test/mjsunit/mjsunit.js#newcode242 ...

6 years, 1 month ago (2014-11-14 10:22:46 UTC) #3

titzer

6 years, 1 month ago (2014-11-14 10:30:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3bcea483a75b8c75f68a286ff191c662055726f2 (presubmit successful).

Expand Messages | Collapse Messages

Issue 724133004: Remove arguments arity check in mjsunit because it vastly slows down the tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove. #

Messages