Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: test/mjsunit/mjsunit.js

Issue 724133004: Remove arguments arity check in mjsunit because it vastly slows down the tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/mjsunit.js
diff --git a/test/mjsunit/mjsunit.js b/test/mjsunit/mjsunit.js
index 043027908853d0dfd9169553dae00a19a3efde55..b360425c6189d486f098223b7b6cc0cf52172472 100644
--- a/test/mjsunit/mjsunit.js
+++ b/test/mjsunit/mjsunit.js
@@ -231,16 +231,7 @@ var assertUnoptimized;
return deepObjectEquals(a, b);
}
- function checkArity(args, arity, name) {
- if (args.length < arity) {
- fail(PrettyPrint(arity), args.length,
- name + " requires " + arity + " or more arguments");
- }
- }
-
assertSame = function assertSame(expected, found, name_opt) {
- checkArity(arguments, 2, "assertSame");
-
// TODO(mstarzinger): We should think about using Harmony's egal operator
// or the function equivalent Object.is() here.
if (found === expected) {
@@ -253,8 +244,6 @@ var assertUnoptimized;
assertEquals = function assertEquals(expected, found, name_opt) {
- checkArity(arguments, 2, "assertEquals");
-
if (!deepEquals(found, expected)) {
fail(PrettyPrint(expected), found, name_opt);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698