Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 724073002: Revert of Make nanobench and dm be usable from Chromium build (Closed)

Created:
6 years, 1 month ago by jcgregorio
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Make nanobench and dm be usable from Chromium build (patchset #5 id:80001 of https://codereview.chromium.org/657373002/) Reason for revert: Causing breakages on Mac build. Original issue's description: > Make nanobench and dm be usable from Chromium build > > Move the app logic for each app as follows: > > <app>.cpp -- the file which contains main(). Embedders that compile > their own apps, such as ios shell, upcoming Chromium dm etc, do not use this. > > <app>_main.cpp -- the main logic of the Skia test application. This will be > used by Skia -compiled apps as well as embedder -compiled apps. > > <app>_main.h -- the API for the main logic. This will be > used by Skia -compiled apps as well as embedder -compiled apps. > > This way (the upcoming) Chromium dm can setup its Chromium-specific setup > in custom main(), and then call dm_main(), without the need of any > SK_BUILD_FOR_XXXX defines controlling whether the tool defines main or not. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/c092d3bdab5f723576cc0346cea3ee282a9cb444 TBR=mtklein@chromium.org,mtklein@google.com,borenet@google.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/3b27adef0a52f6d321fdee7412ef69e7a7284bcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -68 lines) Patch
D bench/nanobench.h View 1 chunk +0 lines, -13 lines 0 comments Download
M bench/nanobench.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
D bench/nanobench_main.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M dm/DM.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
D dm/dm.h View 1 chunk +0 lines, -14 lines 0 comments Download
D dm/dm_main.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/most.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/iOSShell.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jcgregorio
Created Revert of Make nanobench and dm be usable from Chromium build
6 years, 1 month ago (2014-11-13 16:05:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724073002/1
6 years, 1 month ago (2014-11-13 16:06:07 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 16:06:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3b27adef0a52f6d321fdee7412ef69e7a7284bcc

Powered by Google App Engine
This is Rietveld 408576698