Make nanobench and dm be usable from Chromium build

Make nanobench and dm be usable from Chromium build

Move the app logic for each app as follows:

<app>.cpp -- the file which contains main(). Embedders that compile
their own apps, such as ios shell, upcoming Chromium dm etc, do not use this.

<app>_main.cpp -- the main logic of the Skia test application. This will be
used by Skia -compiled apps as well as embedder -compiled apps.

<app>_main.h -- the API for the main logic. This will be
used by Skia -compiled apps as well as embedder -compiled apps.

This way (the upcoming) Chromium dm can setup its Chromium-specific setup
in custom main(), and then call dm_main(), without the need of any
SK_BUILD_FOR_XXXX defines controlling whether the tool defines main or not.

BUG=skia:2992
Committed: https://skia.googlesource.com/skia/+/c092d3bdab5f723576cc0346cea3ee282a9cb444

[Kimmo Kinnunen, 2014-10-16 12:34:38]

kkinnunen@nvidia.com changed reviewers:
+ mtklein@chromium.org

[Kimmo Kinnunen, 2014-10-16 12:34:39]

A bit elaborate with the files, but would this be acceptable?

[mtklein, 2014-10-16 12:58:35]

On 2014/10/16 12:34:39, Kimmo Kinnunen wrote:
> A bit elaborate with the files, but would this be acceptable?

This looks fine to me.  I have two requests:
  1) invert tool.cpp and tool_main.cpp.  Sort of makes sense to have the file
containing main() named _main.cpp.  So nanobench.cpp, nanobench.h,
nanobench_main.cpp.
  2) let's drop bench_pictures.  If there's something you're using it for that
nanobench can't do, we need to add it to nanobench.

[Kimmo Kinnunen, 2014-10-17 05:26:20]

On 2014/10/16 12:58:35, mtklein wrote:
> On 2014/10/16 12:34:39, Kimmo Kinnunen wrote:
> > A bit elaborate with the files, but would this be acceptable?
> 
> This looks fine to me.  I have two requests:
>   1) invert tool.cpp and tool_main.cpp.  Sort of makes sense to have the file
> containing main() named _main.cpp.  So nanobench.cpp, nanobench.h,
> nanobench_main.cpp.
>   2) let's drop bench_pictures.  If there's something you're using it for that
> nanobench can't do, we need to add it to nanobench.

Done.

[mtklein, 2014-10-17 14:28:09]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-10-17 14:28:09]

lgtm

[Kimmo Kinnunen, 2014-10-20 05:01:32]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-10-20 05:02:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657373002/40001

[commit-bot: I haz the power, 2014-10-20 05:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 05:04:40]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[Kimmo Kinnunen, 2014-11-12 08:15:32]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-11-12 08:15:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657373002/60001

[commit-bot: I haz the power, 2014-11-12 08:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-12 08:17:56]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

[Kimmo Kinnunen, 2014-11-12 08:28:42]

On 2014/11/12 08:17:56, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile
>
(http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

Mike (since you tend to know also the infra-related problems),
So there's a patch application problem related to renaming DM.cpp to dm.cpp:

Failed to apply patch for dm/DM.cpp:
While running git rm dm/DM.cpp;
  error: 'dm/dm.cpp' has changes staged in the index
  (use --cached to keep the file, or -f to force removal)


Any idea how to make this patch go in?

[mtklein, 2014-11-12 15:19:51]

mtklein@google.com changed reviewers:
+ borenet@google.com

[mtklein, 2014-11-12 15:19:52]

+Eric, who usually knows how to handle bot problems.  Been seeing those Windows
failures myself, though the Mac one is news to me.

[mtklein, 2014-11-12 15:20:43]

On 2014/11/12 15:19:52, mtklein wrote:
> +Eric, who usually knows how to handle bot problems.  Been seeing those
Windows
> failures myself, though the Mac one is news to me.

Maybe has something to do with Macs using a case-insensitive filesystem?  You
might try renaming dm.cpp DM.cpp.

[borenet, 2014-11-12 15:35:26]

On 2014/11/12 15:20:43, mtklein wrote:
> On 2014/11/12 15:19:52, mtklein wrote:
> > +Eric, who usually knows how to handle bot problems.  Been seeing those
> Windows
> > failures myself, though the Mac one is news to me.
> 
> Maybe has something to do with Macs using a case-insensitive filesystem?  You
> might try renaming dm.cpp DM.cpp.

I think the Windows failure is likely due to a git lockfile being left around. 
I'd have to log in to look, but I'm at home so I can't at the moment,  It's
probably safe to ignore or retry.  I agree with the Mac problem being a result
of case-insensitivity.

[Kimmo Kinnunen, 2014-11-13 06:15:29]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-11-13 06:16:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657373002/80001

[commit-bot: I haz the power, 2014-11-13 06:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 06:31:44]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[Kimmo Kinnunen, 2014-11-13 12:51:54]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-11-13 12:52:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657373002/80001

[commit-bot: I haz the power, 2014-11-13 13:01:08]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/c092d3bdab5f723576cc0346cea3ee282a9cb444

[jcgregorio, 2014-11-13 16:05:12]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/724073002/ by jcgregorio@google.com.

The reason for reverting is: Causing breakages on Mac build..