Simplify GraphicsContext::couldUseLCDRenderedText()

Simplify GraphicsContext::couldUseLCDRenderedText()

After https://codereview.chromium.org/719253002, Skia disables LCD text
for non-opaque save-layers automatically.

Also remove a couple of single-use getters.

R=reed@google.com,jbroman@chromium.org,senorblanco@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185342

[f(malita), 2014-11-13 23:36:22]

fmalita@chromium.org changed reviewers:
+ bungeman@google.com

[f(malita), 2014-11-14 00:54:23]

fmalita@chromium.org changed reviewers:
+ senorblanco@chromium.org
- schenney@chromium.org

[jbroman, 2014-11-14 01:04:01]

lgtm

[Stephen White, 2014-11-14 01:47:04]

LGTM.

BTW, why don't we need the check for contextDisabled()? Not relevant anymore?

[f(malita), 2014-11-14 02:13:57]

On 2014/11/14 01:47:04, Stephen White wrote:
> BTW, why don't we need the check for contextDisabled()? Not relevant anymore?

I don't think it was relevant before either: the method has no side effects, and
with a disabled context we're not going to draw anything anyway (and most likely
we won't even reach this as all GC draw entry points also check for
contextDisabled).

[Stephen White, 2014-11-14 02:16:31]

On 2014/11/14 02:13:57, Florin Malita wrote:
> On 2014/11/14 01:47:04, Stephen White wrote:
> > BTW, why don't we need the check for contextDisabled()? Not relevant
anymore?
> 
> I don't think it was relevant before either: the method has no side effects,
and
> with a disabled context we're not going to draw anything anyway (and most
likely
> we won't even reach this as all GC draw entry points also check for
> contextDisabled).

Makes sense. Thanks for the explanation.

[f(malita), 2014-11-14 02:20:04]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-11-14 02:21:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/724063004/20001

[commit-bot: I haz the power, 2014-11-14 02:23:55]

Committed patchset #2 (id:20001) as 185342

[Stephen Chennney, 2014-11-14 15:30:14]

On 2014/11/14 02:16:31, Stephen White wrote:
> On 2014/11/14 02:13:57, Florin Malita wrote:
> > On 2014/11/14 01:47:04, Stephen White wrote:
> > > BTW, why don't we need the check for contextDisabled()? Not relevant
> anymore?
> > 
> > I don't think it was relevant before either: the method has no side effects,
> and
> > with a disabled context we're not going to draw anything anyway (and most
> likely
> > we won't even reach this as all GC draw entry points also check for
> > contextDisabled).
> 
> Makes sense. Thanks for the explanation.

Probably I added it when guarding all null-canvas access. I don't know if the
code was reachable with a null canvas.