Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index 38abe1ca22d6028b7adc2b072a2ca22826c5ee70..8bbccb225e85ff89ae5b1828fa10a86aa02f5f25 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -252,6 +252,12 @@ public class Tab {
public void visibleSSLStateChanged() {
for (TabObserver observer : mObservers) observer.onSSLStateUpdated(Tab.this);
}
Bernhard Bauer 2014/11/13 09:38:02 Empty line between methods.
AKVT 2014/11/13 09:48:55 Done.
+ @Override
+ public void webContentsCreated(long sourceWebContents, long openerRenderFrameId,
+ String frameName, String targetUrl, long newWebContents) {
+ for (TabObserver observer : mObservers) observer.webContentsCreated(Tab.this,
Bernhard Bauer 2014/11/13 09:38:03 You can only leave out braces if the whole things
AKVT 2014/11/13 09:48:54 Done.
+ sourceWebContents, openerRenderFrameId, frameName, targetUrl, newWebContents);
+ }
}
private class TabContextMenuPopulator extends ContextMenuPopulatorWrapper {

Powered by Google App Engine
This is Rietveld 408576698