chrome/browser/ui/views/frame/browser_view.cc - Issue 723803002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 723803002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/color_chooser_win.cc ('k') | chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 6ed2bca365ae6898b1f4c9c7e0ebd4ff78ca6e29..a00dd6491637420b541e9aa60d2951d7a345ae17 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -419,7 +419,7 @@ BrowserView::~BrowserView() {

// Terminate the jumplist (must be called before browser_->profile() is

// destroyed.

- if (jumplist_) {

+ if (jumplist_.get()) {

jumplist_->Terminate();

}

#endif

@@ -2020,7 +2020,7 @@ void BrowserView::LoadingAnimationCallback() {

void BrowserView::OnLoadCompleted() {

#if defined(OS_WIN)

- DCHECK(!jumplist_);

+ DCHECK(!jumplist_.get());

jumplist_ = new JumpList(browser_->profile());

#endif

}