chrome/browser/ui/views/color_chooser_win.cc - Issue 723803002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/color_chooser_win.cc

Issue 723803002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/color_chooser_win.cc

diff --git a/chrome/browser/ui/views/color_chooser_win.cc b/chrome/browser/ui/views/color_chooser_win.cc

index 041aa7f740f3962acc8e36ab2ca0c836379f6a44..ce4ee36d36fe0e702682f3c52cc6d41a6de52d2e 100644

--- a/chrome/browser/ui/views/color_chooser_win.cc

+++ b/chrome/browser/ui/views/color_chooser_win.cc

@@ -66,7 +66,7 @@ ColorChooserWin::ColorChooserWin(content::WebContents* web_contents,

ColorChooserWin::~ColorChooserWin() {

// Always call End() before destroying.

- DCHECK(!color_chooser_dialog_);

+ DCHECK(!color_chooser_dialog_.get());

}

void ColorChooserWin::End() {

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »