Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 723803002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/312ba642cc708dfc5e1dcf90c0197d4258442186 Cr-Commit-Position: refs/heads/master@{#303938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/ui/views/color_chooser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Time to finish this cleanup.
6 years, 1 month ago (2014-11-12 22:58:05 UTC) #2
msw
lgtm
6 years, 1 month ago (2014-11-12 23:04:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723803002/1
6 years, 1 month ago (2014-11-12 23:07:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 00:43:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:44:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/312ba642cc708dfc5e1dcf90c0197d4258442186
Cr-Commit-Position: refs/heads/master@{#303938}

Powered by Google App Engine
This is Rietveld 408576698