Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 723743003: Remove implicit conversions from scoped_refptr to T* in printing/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in printing/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/be20825ffd218323b94626bb069a1980accf5289 Cr-Commit-Position: refs/heads/master@{#304105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M printing/backend/print_backend_win.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 1 month ago (2014-11-12 23:26:59 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 1 month ago (2014-11-13 21:56:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723743003/1
6 years, 1 month ago (2014-11-13 21:58:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 23:07:00 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:07:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be20825ffd218323b94626bb069a1980accf5289
Cr-Commit-Position: refs/heads/master@{#304105}

Powered by Google App Engine
This is Rietveld 408576698