Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: printing/backend/print_backend_win.cc

Issue 723743003: Remove implicit conversions from scoped_refptr to T* in printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | printing/backend/win_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/print_backend_win.cc
diff --git a/printing/backend/print_backend_win.cc b/printing/backend/print_backend_win.cc
index 0f5d0964c050933570169a60dba4a766845e6175..a95c98be4235a79cb26f67f0bc5b3f814bda62a3 100644
--- a/printing/backend/print_backend_win.cc
+++ b/printing/backend/print_backend_win.cc
@@ -304,12 +304,10 @@ bool PrintBackendWin::GetPrinterCapsAndDefaults(
hr = CreateStreamOnHGlobal(NULL, TRUE,
print_capabilities_stream.Receive());
DCHECK(SUCCEEDED(hr));
- if (print_capabilities_stream) {
+ if (print_capabilities_stream.get()) {
base::win::ScopedBstr error;
- hr = XPSModule::GetPrintCapabilities(provider,
- NULL,
- print_capabilities_stream,
- error.Receive());
+ hr = XPSModule::GetPrintCapabilities(
+ provider, NULL, print_capabilities_stream.get(), error.Receive());
DCHECK(SUCCEEDED(hr));
if (FAILED(hr)) {
return false;
@@ -329,10 +327,11 @@ bool PrintBackendWin::GetPrinterCapsAndDefaults(
hr = CreateStreamOnHGlobal(NULL, TRUE,
printer_defaults_stream.Receive());
DCHECK(SUCCEEDED(hr));
- if (printer_defaults_stream) {
+ if (printer_defaults_stream.get()) {
DWORD dm_size = devmode_out->dmSize + devmode_out->dmDriverExtra;
- hr = XPSModule::ConvertDevModeToPrintTicket(provider, dm_size,
- devmode_out.get(), kPTJobScope, printer_defaults_stream);
+ hr = XPSModule::ConvertDevModeToPrintTicket(
+ provider, dm_size, devmode_out.get(), kPTJobScope,
+ printer_defaults_stream.get());
DCHECK(SUCCEEDED(hr));
if (SUCCEEDED(hr)) {
hr = StreamOnHGlobalToString(printer_defaults_stream.get(),
« no previous file with comments | « no previous file | printing/backend/win_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698