Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 723643002: Service Worker: Include promise types in IDL (Closed)

Created:
6 years, 1 month ago by jsbell
Modified:
6 years, 1 month ago
Reviewers:
michaeln
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Service Worker: Include promise types in IDL The Chromium IDL parser was updated to support Promise<T> syntax. Update the IDLs to include types from the spec. Note that the type isn't actually used for anything so this is a no-op change, for documentation only. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185381

Patch Set 1 #

Patch Set 2 : Promise<void> #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M Source/modules/serviceworkers/Body.idl View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/Cache.idl View 1 1 chunk +7 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jsbell
michaeln@ - please take a look?
6 years, 1 month ago (2014-11-13 20:53:47 UTC) #2
michaeln
lgtm
6 years, 1 month ago (2014-11-14 01:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723643002/40001
6 years, 1 month ago (2014-11-14 17:09:29 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 17:49:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185381

Powered by Google App Engine
This is Rietveld 408576698