Source/modules/serviceworkers/ServiceWorkerContainer.idl - Issue 723643002: Service Worker: Include promise types in IDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.idl

Issue 723643002: Service Worker: Include promise types in IDL (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerClients.idl ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainer.idl

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.idl b/Source/modules/serviceworkers/ServiceWorkerContainer.idl

index caf25ba965118effba44816522d98dff49ac062f..27839ec7c8fe088c171a637291dd7e73bbbae81a 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.idl

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.idl

@@ -35,8 +35,9 @@

TypeChecking=Interface,

] interface ServiceWorkerContainer {

[Unforgeable] readonly attribute ServiceWorker? controller;

- [CallWith=ScriptState] readonly attribute Promise ready;

+ [CallWith=ScriptState] readonly attribute Promise<ServiceWorkerRegistration> ready;

- [CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise register(USVString url, optional RegistrationOptions options);

- [CallWith=ScriptState] Promise getRegistration(optional USVString documentURL = "");

+ [CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise<ServiceWorkerRegistration> register(USVString url, optional RegistrationOptions options);

+ [CallWith=ScriptState] Promise<ServiceWorkerRegistration> getRegistration(optional USVString documentURL = "");

};