Add Non-SFI test for a NaCl packaged app.

Add Non-SFI test for a NaCl packaged app.

There is currently no test for packaged apps for NaCl plugins running in
Non-SFI mode. This change increases test coverage.

BUG=none
TEST=Manually tested in a 32-bit chroot
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32

Committed: https://crrev.com/e5d4e9e0b73e29030945726b3b44eda22e89d3ec
Cr-Commit-Position: refs/heads/master@{#303997}

Committed: https://crrev.com/eefe3baf67d545b88e4b7e694072c20b57c59318
Cr-Commit-Position: refs/heads/master@{#304084}

[teravest, 2014-11-12 18:13:59]

Patchset #1 (id:1) has been deleted

[teravest, 2014-11-12 18:26:22]

teravest@chromium.org changed reviewers:
+ dmichael@chromium.org

[dmichael (off chromium), 2014-11-12 18:49:14]

nits, o/w lgtm

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
File chrome/test/ppapi/ppapi_browsertest.cc (right):

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1342: virtual void SetUpOnMainThread()
override {
nit: Newly preferred style is only to use override *or* virtual, not both. So
override in this case?

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1384: toolchain_ = "nonsfi";
nit: Better to do it in the initializer list (here and in NewlibPackagedAppTest)

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1386: virtual void
SetUpCommandLine(base::CommandLine* command_line) {
nit: override instead of virtual?

https://codereview.chromium.org/723623002/diff/20001/ppapi/tests/extensions/e...
File ppapi/tests/extensions/extensions.gyp (right):

https://codereview.chromium.org/723623002/diff/20001/ppapi/tests/extensions/e...
ppapi/tests/extensions/extensions.gyp:57: # TODO(teravest): Add testing for
glibc, pnacl, and nonsfi modes.
nit: This TODO can go away now

[teravest, 2014-11-12 20:01:31]

The CQ bit was checked by teravest@chromium.org

[teravest, 2014-11-12 20:01:34]

The CQ bit was unchecked by teravest@chromium.org

[teravest, 2014-11-12 20:02:06]

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
File chrome/test/ppapi/ppapi_browsertest.cc (right):

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1342: virtual void SetUpOnMainThread()
override {
On 2014/11/12 18:49:13, dmichael wrote:
> nit: Newly preferred style is only to use override *or* virtual, not both. So
> override in this case?

I just removed this method.

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1384: toolchain_ = "nonsfi";
On 2014/11/12 18:49:13, dmichael wrote:
> nit: Better to do it in the initializer list (here and in
NewlibPackagedAppTest)

Done.

https://codereview.chromium.org/723623002/diff/20001/chrome/test/ppapi/ppapi_...
chrome/test/ppapi/ppapi_browsertest.cc:1386: virtual void
SetUpCommandLine(base::CommandLine* command_line) {
On 2014/11/12 18:49:13, dmichael wrote:
> nit: override instead of virtual?

Done.

https://codereview.chromium.org/723623002/diff/20001/ppapi/tests/extensions/e...
File ppapi/tests/extensions/extensions.gyp (right):

https://codereview.chromium.org/723623002/diff/20001/ppapi/tests/extensions/e...
ppapi/tests/extensions/extensions.gyp:57: # TODO(teravest): Add testing for
glibc, pnacl, and nonsfi modes.
On 2014/11/12 18:49:14, dmichael wrote:
> nit: This TODO can go away now

Done.

[teravest, 2014-11-12 20:02:10]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-11-12 20:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723623002/60001

[commit-bot: I haz the power, 2014-11-13 06:24:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-11-13 06:24:55]

Patchset 3 (id:??) landed as
https://crrev.com/e5d4e9e0b73e29030945726b3b44eda22e89d3ec
Cr-Commit-Position: refs/heads/master@{#303997}

[teravest, 2014-11-13 20:04:45]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-11-13 20:05:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/723623002/80001

[commit-bot: I haz the power, 2014-11-13 21:28:44]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-11-13 21:30:17]

Patchset 4 (id:??) landed as
https://crrev.com/eefe3baf67d545b88e4b7e694072c20b57c59318
Cr-Commit-Position: refs/heads/master@{#304084}