Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 723593002: Start stripping out complicated parts of SkPicture{Record,Data}. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Start stripping out complicated parts of SkPicture{Record,Data}. First step: no more paint flattening or deduplication. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a74ce853c824c5ae30e219ddf46a61d91cc0ab2a

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -131 lines) Patch
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +0 lines, -43 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 3 chunks +2 lines, -7 lines 2 comments Download
M tests/BitmapHeapTest.cpp View 3 chunks +8 lines, -2 lines 1 comment Download
D tests/FlatDataTest.cpp View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years, 1 month ago (2014-11-12 17:09:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723593002/1
6 years, 1 month ago (2014-11-12 17:10:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 17:10:06 UTC) #5
robertphillips
https://codereview.chromium.org/723593002/diff/1/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.chromium.org/723593002/diff/1/src/core/SkPictureRecord.cpp#newcode924 src/core/SkPictureRecord.cpp:924: if (paint) { I think 0 is used as ...
6 years, 1 month ago (2014-11-12 17:14:42 UTC) #6
robertphillips
lgtm https://codereview.chromium.org/723593002/diff/1/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.chromium.org/723593002/diff/1/src/core/SkPictureRecord.cpp#newcode924 src/core/SkPictureRecord.cpp:924: if (paint) { On 2014/11/12 17:14:42, robertphillips wrote: ...
6 years, 1 month ago (2014-11-12 17:17:52 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 17:19:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a74ce853c824c5ae30e219ddf46a61d91cc0ab2a

Powered by Google App Engine
This is Rietveld 408576698