Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: sky/engine/core/html/imports/HTMLImportLoader.cpp

Issue 723583002: Make the parser an implementation detail of the Document (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/imports/HTMLImportLoader.cpp
diff --git a/sky/engine/core/html/imports/HTMLImportLoader.cpp b/sky/engine/core/html/imports/HTMLImportLoader.cpp
index 84ae5695b3a262c93f4e95f017d28f816fbe7c49..0b24a254b533cfca17bd67bd60ce583b2420149f 100644
--- a/sky/engine/core/html/imports/HTMLImportLoader.cpp
+++ b/sky/engine/core/html/imports/HTMLImportLoader.cpp
@@ -103,8 +103,7 @@ HTMLImportLoader::State HTMLImportLoader::startWritingAndParsing(mojo::URLRespon
.withRegistrationContext(m_controller->master()->registrationContext());
m_document = HTMLDocument::create(init);
m_module = Module::create(contextDocument.get(), nullptr, m_document.get(), url.string());
- m_document->startParsing();
- m_document->parser()->parse(response->body.Pass());
+ m_document->startParsing()->parse(response->body.Pass());
eseidel 2014/11/12 19:02:14 Should this just take the mojo pipe in the startPa
abarth-chromium 2014/11/12 21:13:57 Yes, that would be sensible, but in a later CL in
return StateLoading;
}

Powered by Google App Engine
This is Rietveld 408576698