sky/engine/core/dom/StyleElement.cpp - Issue 723583002: Make the parser an implementation detail of the Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/StyleElement.cpp

Issue 723583002: Make the parser an implementation detail of the Document (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/StyleElement.cpp

diff --git a/sky/engine/core/dom/StyleElement.cpp b/sky/engine/core/dom/StyleElement.cpp

index b4e856349e8903b323b3e495fd31e6537b8c48d6..4ab8f1a5a82b6bf72a97bca4e0b32112cc36ef2a 100644

--- a/sky/engine/core/dom/StyleElement.cpp

+++ b/sky/engine/core/dom/StyleElement.cpp

@@ -47,8 +47,8 @@ StyleElement::StyleElement(Document* document, bool createdByParser)

, m_registeredAsCandidate(false)

, m_startPosition(TextPosition::belowRangePosition())

{

- if (createdByParser && document && document->scriptableDocumentParser())

- m_startPosition = document->scriptableDocumentParser()->textPosition();

+ if (createdByParser)

+ m_startPosition = document->textPosition();

}

StyleElement::~StyleElement()