Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: net/cert/ct_log_verifier_unittest.cc

Issue 72333007: Add an SignedCertificateTimetampStore, making SignedCertificateTimestamp be refcounted to aid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@piecewise
Patch Set: Fixes for wtc. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_log_verifier_unittest.cc
diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc
index 4412258875615d9b1e6bf24661051fc40437da84..b94f14a11c2f79fd054761460e20db37988d91e7 100644
--- a/net/cert/ct_log_verifier_unittest.cc
+++ b/net/cert/ct_log_verifier_unittest.cc
@@ -32,47 +32,47 @@ TEST_F(CTLogVerifierTest, VerifiesCertSCT) {
ct::LogEntry cert_entry;
ct::GetX509CertLogEntry(&cert_entry);
- ct::SignedCertificateTimestamp cert_sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
ct::GetX509CertSCT(&cert_sct);
- EXPECT_TRUE(log_->Verify(cert_entry, cert_sct));
+ EXPECT_TRUE(log_->Verify(cert_entry, *cert_sct));
}
TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
ct::LogEntry precert_entry;
ct::GetPrecertLogEntry(&precert_entry);
- ct::SignedCertificateTimestamp precert_sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> precert_sct;
ct::GetPrecertSCT(&precert_sct);
- EXPECT_TRUE(log_->Verify(precert_entry, precert_sct));
+ EXPECT_TRUE(log_->Verify(precert_entry, *precert_sct));
}
TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
ct::LogEntry cert_entry;
ct::GetX509CertLogEntry(&cert_entry);
- ct::SignedCertificateTimestamp cert_sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
ct::GetX509CertSCT(&cert_sct);
// Mangle the timestamp, so that it should fail signature validation.
- cert_sct.timestamp = base::Time::Now();
+ cert_sct->timestamp = base::Time::Now();
- EXPECT_FALSE(log_->Verify(cert_entry, cert_sct));
+ EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
}
TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
ct::LogEntry cert_entry;
ct::GetX509CertLogEntry(&cert_entry);
- ct::SignedCertificateTimestamp cert_sct;
+ scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
ct::GetX509CertSCT(&cert_sct);
// Mangle the log ID, which should cause it to match a different log before
// attempting signature validation.
- cert_sct.log_id.assign(cert_sct.log_id.size(), '\0');
+ cert_sct->log_id.assign(cert_sct->log_id.size(), '\0');
- EXPECT_FALSE(log_->Verify(cert_entry, cert_sct));
+ EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698