Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: net/cert/ct_log_verifier_unittest.cc

Issue 72333007: Add an SignedCertificateTimetampStore, making SignedCertificateTimestamp be refcounted to aid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@piecewise
Patch Set: Fixes for wtc. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/ct_log_verifier.h" 5 #include "net/cert/ct_log_verifier.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "net/cert/signed_certificate_timestamp.h" 10 #include "net/cert/signed_certificate_timestamp.h"
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 26
27 protected: 27 protected:
28 scoped_ptr<CTLogVerifier> log_; 28 scoped_ptr<CTLogVerifier> log_;
29 }; 29 };
30 30
31 TEST_F(CTLogVerifierTest, VerifiesCertSCT) { 31 TEST_F(CTLogVerifierTest, VerifiesCertSCT) {
32 ct::LogEntry cert_entry; 32 ct::LogEntry cert_entry;
33 ct::GetX509CertLogEntry(&cert_entry); 33 ct::GetX509CertLogEntry(&cert_entry);
34 34
35 ct::SignedCertificateTimestamp cert_sct; 35 scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
36 ct::GetX509CertSCT(&cert_sct); 36 ct::GetX509CertSCT(&cert_sct);
37 37
38 EXPECT_TRUE(log_->Verify(cert_entry, cert_sct)); 38 EXPECT_TRUE(log_->Verify(cert_entry, *cert_sct));
39 } 39 }
40 40
41 TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) { 41 TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
42 ct::LogEntry precert_entry; 42 ct::LogEntry precert_entry;
43 ct::GetPrecertLogEntry(&precert_entry); 43 ct::GetPrecertLogEntry(&precert_entry);
44 44
45 ct::SignedCertificateTimestamp precert_sct; 45 scoped_refptr<ct::SignedCertificateTimestamp> precert_sct;
46 ct::GetPrecertSCT(&precert_sct); 46 ct::GetPrecertSCT(&precert_sct);
47 47
48 EXPECT_TRUE(log_->Verify(precert_entry, precert_sct)); 48 EXPECT_TRUE(log_->Verify(precert_entry, *precert_sct));
49 } 49 }
50 50
51 TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) { 51 TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
52 ct::LogEntry cert_entry; 52 ct::LogEntry cert_entry;
53 ct::GetX509CertLogEntry(&cert_entry); 53 ct::GetX509CertLogEntry(&cert_entry);
54 54
55 ct::SignedCertificateTimestamp cert_sct; 55 scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
56 ct::GetX509CertSCT(&cert_sct); 56 ct::GetX509CertSCT(&cert_sct);
57 57
58 // Mangle the timestamp, so that it should fail signature validation. 58 // Mangle the timestamp, so that it should fail signature validation.
59 cert_sct.timestamp = base::Time::Now(); 59 cert_sct->timestamp = base::Time::Now();
60 60
61 EXPECT_FALSE(log_->Verify(cert_entry, cert_sct)); 61 EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
62 } 62 }
63 63
64 TEST_F(CTLogVerifierTest, FailsInvalidLogID) { 64 TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
65 ct::LogEntry cert_entry; 65 ct::LogEntry cert_entry;
66 ct::GetX509CertLogEntry(&cert_entry); 66 ct::GetX509CertLogEntry(&cert_entry);
67 67
68 ct::SignedCertificateTimestamp cert_sct; 68 scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
69 ct::GetX509CertSCT(&cert_sct); 69 ct::GetX509CertSCT(&cert_sct);
70 70
71 // Mangle the log ID, which should cause it to match a different log before 71 // Mangle the log ID, which should cause it to match a different log before
72 // attempting signature validation. 72 // attempting signature validation.
73 cert_sct.log_id.assign(cert_sct.log_id.size(), '\0'); 73 cert_sct->log_id.assign(cert_sct->log_id.size(), '\0');
74 74
75 EXPECT_FALSE(log_->Verify(cert_entry, cert_sct)); 75 EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
76 } 76 }
77 77
78 } // namespace net 78 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698