pkg/analysis_server/test/services/completion/completion_manager_test.dart - Issue 723263004: make completion managers responsible for their own caches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_manager_test.dart

Issue 723263004: make completion managers responsible for their own caches (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/completion_computer_test.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_manager_test.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_manager_test.dart b/pkg/analysis_server/test/services/completion/completion_manager_test.dart

index 4a983a243873325e68d452592bcfe58402d16b38..5185bdc41c3688c90f02bb6fed12abacc56edb00 100644

--- a/pkg/analysis_server/test/services/completion/completion_manager_test.dart

+++ b/pkg/analysis_server/test/services/completion/completion_manager_test.dart

@@ -25,28 +25,28 @@ class CompletionManagerTest extends AbstractContextTest {

test_dart() {

Source source = addSource('/does/not/exist.dart', '');

var manager =

- new CompletionManager.create(context, source, 0, null, cache, perf);

+ new CompletionManager.create(context, source, null, cache);

expect(manager.runtimeType, DartCompletionManager);

}

test_html() {

Source source = addSource('/does/not/exist.html', '');

var manager =

- new CompletionManager.create(context, source, 0, null, cache, perf);

+ new CompletionManager.create(context, source, null, cache);

expect(manager.runtimeType, NoOpCompletionManager);

}

test_null_context() {

Source source = addSource('/does/not/exist.dart', '');

var manager =

- new CompletionManager.create(null, source, 0, null, cache, perf);

+ new CompletionManager.create(null, source, null, cache);

expect(manager.runtimeType, NoOpCompletionManager);

}

test_other() {

Source source = addSource('/does/not/exist.foo', '');

var manager =

- new CompletionManager.create(context, source, 0, null, cache, perf);

+ new CompletionManager.create(context, source, null, cache);

expect(manager.runtimeType, NoOpCompletionManager);

}