Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 723223005: bookmarks: Cleanup - Rename 'OtherBookmarked' to 'OtherBookmarks'. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Cleanup - Rename 'OtherBookmarked' to 'OtherBookmarks'. The name of the folder shown in the Bookmarks Bar is "Other Bookmarks" not "Other Bookmarked". Rename the function and the member variable to say "OtherBookmarks" and "other_bookmarks". BUG=None R=sky@chromium.org Committed: https://crrev.com/5f1594798481812d903fb921f48c92e565b399bf Cr-Commit-Position: refs/heads/master@{#307837}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -69 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 21 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 14 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years ago (2014-12-10 03:27:25 UTC) #1
sky
LGTM
6 years ago (2014-12-10 15:43:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723223005/20001
6 years ago (2014-12-10 23:23:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 02:13:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 02:14:05 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f1594798481812d903fb921f48c92e565b399bf
Cr-Commit-Position: refs/heads/master@{#307837}

Powered by Google App Engine
This is Rietveld 408576698