Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 723223005: bookmarks: Cleanup - Rename 'OtherBookmarked' to 'OtherBookmarks'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: REBASE Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index d150d8a9d949ab70bf47189824b05d45ad048d71..24bc6bb4e947b24ae8feb63d4e17867347dede55 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -120,10 +120,10 @@ class BookmarkBarView : public DetachableToolbarView,
void GetAnchorPositionForButton(views::MenuButton* button,
views::MenuAnchorPosition* anchor);
- // Returns the button responsible for showing bookmarks in the other bookmark
- // folder.
- views::MenuButton* other_bookmarked_button() const {
- return other_bookmarked_button_;
+ // Returns the button responsible for showing bookmarks in the
+ // "Other Bookmarks" folder.
+ views::MenuButton* other_bookmarks_button() const {
+ return other_bookmarks_button_;
}
// Returns the button used when not all the items on the bookmark bar fit.
@@ -290,10 +290,10 @@ class BookmarkBarView : public DetachableToolbarView,
// visible, this returns GetBookmarkButtonCount().
int GetFirstHiddenNodeIndex();
- // Creates the button showing the other bookmarked items.
- views::MenuButton* CreateOtherBookmarkedButton();
+ // Creates the button showing the "Other Bookmarks" folder.
+ views::MenuButton* CreateOtherBookmarksButton();
- // Creates the button showing the managed bookmarks items.
+ // Creates the button showing the "Managed Bookmarks" folder.
views::MenuButton* CreateManagedBookmarksButton();
// Creates the button used when not all bookmark buttons fit.
@@ -359,7 +359,7 @@ class BookmarkBarView : public DetachableToolbarView,
// Updates the colors for all the child objects in the bookmarks bar.
void UpdateColors();
- // Updates the visibility of |other_bookmarked_button_| and
+ // Updates the visibility of |other_bookmarks_button_| and
// |managed_bookmarks_button_|. Also shows or hides the separator if required.
// Returns true if something changed and a LayoutAndPaint() is needed.
bool UpdateOtherAndManagedButtonsVisibility();
@@ -403,8 +403,8 @@ class BookmarkBarView : public DetachableToolbarView,
// bookmark bar.
scoped_ptr<BookmarkContextMenu> context_menu_;
- // Shows the other bookmark entries.
- views::MenuButton* other_bookmarked_button_;
+ // Shows the "Other Bookmarks" folder button.
+ views::MenuButton* other_bookmarks_button_;
// Shows the managed bookmarks entries.
views::MenuButton* managed_bookmarks_button_;
@@ -434,8 +434,8 @@ class BookmarkBarView : public DetachableToolbarView,
scoped_ptr<gfx::SlideAnimation> size_animation_;
// If the bookmark bubble is showing, this is the visible ancestor of the URL.
- // The visible ancestor is either the other_bookmarked_button_,
- // overflow_button_ or a button on the bar.
+ // The visible ancestor is either the |other_bookmarks_button_|,
+ // |overflow_button_| or a button on the bar.
views::CustomButton* throbbing_view_;
BookmarkBar::State bookmark_bar_state_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698