Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 723223004: Using FLAG_ACTIVITY_NEW_TASK flag for sharing in Chrome Shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
index b5b15935dde7f79d334fa0c01ae43b2cbd46ed94..5b4e36592d9b1caef8eeeeef8957e1557cf12cf8 100644
--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java
@@ -353,9 +353,9 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe
mTabManager.createNewTab();
return true;
} else if (id == R.id.share_menu_id || id == R.id.direct_share_menu_id) {
- ShareHelper.share(item.getItemId() == R.id.direct_share_menu_id, this,
- activeTab.getTitle(), activeTab.getUrl(), null,
- Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET);
+ ShareHelper.share(item.getItemId() == R.id.direct_share_menu_id,
+ this, activeTab.getTitle(), activeTab.getUrl(), null,
aurimas (slooooooooow) 2014/11/19 22:43:17 Undo "this" wrapping to the new line as it has not
deepak.db 2014/11/21 10:14:45 Done.
+ Intent.FLAG_ACTIVITY_NEW_TASK);
aurimas (slooooooooow) 2014/11/19 22:43:17 Use ChromeApiCompatibilityUtils.getActivityNewDocu
deepak.db 2014/11/20 07:29:05 Thanks for the reply! FLAG_ACTIVITY_CLEAR_WHEN_TAS
aurimas (slooooooooow) 2014/11/20 17:24:04 FLAG_ACTIVITY_NEW_DOCUMENT and FLAG_ACTIVITY_NEW_T
deepak.db 2014/11/21 10:14:45 ChromeApiCompatibilityUtils.getActivityNewDocument
return true;
} else {
return super.onOptionsItemSelected(item);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698