Using FLAG_ACTIVITY_NEW_TASK flag for sharing in Chrome Shell.

chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.shell;
 
 import android.app.Activity;
 import android.content.Intent;
 import android.os.Bundle;
 import android.text.TextUtils;
@@ skipping 335 matching lines @@
             return true;
         } else if (id == R.id.forward_menu_id) {
             if (activeTab != null && activeTab.canGoForward()) {
                 activeTab.goForward();
             }
             return true;
         } else if (id == R.id.new_tab_menu_id) {
             mTabManager.createNewTab();
             return true;
         } else if (id == R.id.share_menu_id || id == R.id.direct_share_menu_id) {
-            ShareHelper.share(item.getItemId() == R.id.direct_share_menu_id, this,
-                    activeTab.getTitle(), activeTab.getUrl(), null,
-                    Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET);
+            ShareHelper.share(item.getItemId() == R.id.direct_share_menu_id,
+                    this, activeTab.getTitle(), activeTab.getUrl(), null,

[aurimas (slooooooooow), 2014/11/19 22:43:17]

Undo "this" wrapping to the new line as it has nothing to do with this CL.

[deepak.db, 2014/11/21 10:14:45]

Done.

+                    Intent.FLAG_ACTIVITY_NEW_TASK);

[aurimas (slooooooooow), 2014/11/19 22:43:17]

Use ChromeApiCompatibilityUtils.getActivityNewDocumentFlag() instead of
hardcoding the flag.

[deepak.db, 2014/11/20 07:29:05]

Thanks for the reply!
FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET flag is depricated in API 21 and it performs
identical to new added  FLAG_ACTIVITY_NEW_DOCUMENT flag. So with
FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET flag, there is different behavior observed
in Lollipop and previous versions of Android.
See the screenshots attached in bug 435004 (I am unable to add you in cc).
So I thought of passing FLAG_ACTIVITY_NEW_TASK Intent flag which is available
from API 1 and this flag will have same effect in all the versions of android ie
even in older version two separate tasks will be shown in application switcher
similar to Lollipop.
Also if we use FLAG_ACTIVITY_NEW_TASK Intent flag we can avoid extra code in
APICompatibilityUtils class.
PTAL

[aurimas (slooooooooow), 2014/11/20 17:24:04]

FLAG_ACTIVITY_NEW_DOCUMENT and FLAG_ACTIVITY_NEW_TASK are not the same.

http://developer.android.com/reference/android/content/Intent.html#FLAG_ACTIV...

[deepak.db, 2014/11/21 10:14:45]

ChromeApiCompatibilityUtils.getActivityNewDocumentFlag() used as per your review
comments. Thanks.
Done.
PTAL

             return true;
         } else {
             return super.onOptionsItemSelected(item);
         }
     }
 
     private void waitForDebuggerIfNeeded() {
         if (CommandLine.getInstance().hasSwitch(BaseSwitches.WAIT_FOR_JAVA_DEBUGGER)) {
             Log.e(TAG, "Waiting for Java debugger to connect...");
             android.os.Debug.waitForDebugger();
@@ skipping 64 matching lines @@
     @VisibleForTesting
     public static void setActivityWindowAndroidFactory(ActivityWindowAndroidFactory factory) {
         sWindowAndroidFactory = factory;
     }
 
     @VisibleForTesting
     public static void setAppMenuHandlerFactory(AppMenuHandlerFactory factory) {
         sAppMenuHandlerFactory = factory;
     }
 }