Issue 723053002: Files.app: Add guard closure for selectedAsyncData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723053002: Files.app: Add guard closure for selectedAsyncData. (Closed)

Created:
6 years, 1 month ago by hirono

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Add guard closure for selectedAsyncData. The FileTransferController#selectedAsyncData is cache of data that cannot be obtained synchronously. This is needed for assigning the data to DataTransfer in the event handler. The data can be null if the event is dispatched before the data is obtained. BUG=431650 TEST=None TBR=fukino Review URL: https://codereview.chromium.org/704333003 Cr-Commit-Position: refs/heads/master@{#303444} (cherry picked from commit 5bb64a5b8ff45d1326552f70f687f378a76af97f) Committed: https://chromium.googlesource.com/chromium/src/+/9aa8420e0f237267a3d612f749872884af378388

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ui/file_manager/file_manager/foreground/js/file_transfer_controller.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

hirono

6 years, 1 month ago (2014-11-13 07:54:30 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9aa8420e0f237267a3d612f749872884af378388 (presubmit successful).

Expand Messages | Collapse Messages