Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 704333003: Files.app: Add guard closure for selectedAsyncData. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add guard closure for selectedAsyncData. The FileTransferController#selectedAsyncData is cache of data that cannot be obtained synchronously. This is needed for assigning the data to DataTransfer in the event handler. The data can be null if the event is dispatched before the data is obtained. BUG=431650 TEST=None Committed: https://crrev.com/5bb64a5b8ff45d1326552f70f687f378a76af97f Cr-Commit-Position: refs/heads/master@{#303444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hirono
PTAL the CL? Thanks!
6 years, 1 month ago (2014-11-10 09:22:54 UTC) #2
fukino
On 2014/11/10 09:22:54, hirono wrote: > PTAL the CL? Thanks! lgtm
6 years, 1 month ago (2014-11-10 09:48:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704333003/1
6 years, 1 month ago (2014-11-10 09:49:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 10:34:31 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 10:35:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bb64a5b8ff45d1326552f70f687f378a76af97f
Cr-Commit-Position: refs/heads/master@{#303444}

Powered by Google App Engine
This is Rietveld 408576698