Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(68)

Issue 7230053: Modify TemplateURLRef to remove unknown URL parameters, but only when it represents a prepopulate... (Closed)

Created:
7 years, 9 months ago by SteveT
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina, PaweĊ‚ Hajdan Jr., dhollowa
Visibility:
Public.

Description

Modify TemplateURLRef to remove unknown URL parameters, but only when it represents a prepopulated URL. Also removing a friend function ParseParameterReallyUnknown which was accidentally added in r90764. TEST=Ensure all TemplateURLTest unit tests succeed. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90845

Patch Set 1 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -17 lines) Patch
M chrome/browser/importer/profile_import_process_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url.h View 5 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 4 chunks +21 lines, -3 lines 1 comment Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 2 chunks +36 lines, -3 lines 1 comment Download
M chrome/browser/webdata/keyword_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
SteveT
Here are the changes we discussed by email. PTAL.
7 years, 9 months ago (2011-06-28 20:11:55 UTC) #1
sky
LGTM http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engines/template_url.cc File chrome/browser/search_engines/template_url.cc (right): http://codereview.chromium.org/7230053/diff/4002/chrome/browser/search_engines/template_url.cc#newcode694 chrome/browser/search_engines/template_url.cc:694: if (id > 0) Convert these to SetTemplateURLRefsPrepopulate(id ...
7 years, 9 months ago (2011-06-28 21:02:26 UTC) #2
commit-bot: I haz the power
7 years, 9 months ago (2011-06-28 22:15:48 UTC) #3
Change committed as 90845

Powered by Google App Engine
This is Rietveld 408576698