Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 722823002: gpu: Make sure sync queries complete on service side when calling glFinish.

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

gpu: Make sure sync queries complete on service side when calling glFinish. This is a correctness fix as we can't assume GLFence::HasCompleted() will return true after glFinish has been called. BUG=430933 Review URL: https://codereview.chromium.org/707833003 Cr-Commit-Position: refs/heads/master@{#303584} (cherry picked from commit cc241eb2e305df9d467991521dd753d7b398884a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -42 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager.h View 2 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 17 chunks +26 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698