Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 707833003: gpu: Make sure sync queries complete on service side when calling glFinish. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Make sure sync queries complete on service side when calling glFinish. This is a correctness fix as we can't assume GLFence::HasCompleted() will return true after glFinish has been called. BUG=430933 Committed: https://crrev.com/cc241eb2e305df9d467991521dd753d7b398884a Cr-Commit-Position: refs/heads/master@{#303584}

Patch Set 1 #

Patch Set 2 : wait_if_supported -> did_finish and add some checks to help diagnose these errors #

Total comments: 1

Patch Set 3 : turn CHECKs into DCHECKs #

Patch Set 4 : Remove DCHECKs #

Patch Set 5 : update TODO and add bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -42 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 2 3 4 17 chunks +26 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reveman
6 years, 1 month ago (2014-11-06 17:34:17 UTC) #1
reveman
I changed the patch as discussed. PTAL. https://codereview.chromium.org/707833003/diff/20001/gpu/command_buffer/service/query_manager.cc File gpu/command_buffer/service/query_manager.cc (right): https://codereview.chromium.org/707833003/diff/20001/gpu/command_buffer/service/query_manager.cc#newcode445 gpu/command_buffer/service/query_manager.cc:445: client_wait_duration.InSeconds(); Maybe ...
6 years, 1 month ago (2014-11-06 23:51:15 UTC) #2
piman
lgtm
6 years, 1 month ago (2014-11-10 18:36:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707833003/80001
6 years, 1 month ago (2014-11-10 20:30:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20756)
6 years, 1 month ago (2014-11-10 21:09:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707833003/80001
6 years, 1 month ago (2014-11-10 21:37:42 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-11 03:30:45 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 03:32:17 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cc241eb2e305df9d467991521dd753d7b398884a
Cr-Commit-Position: refs/heads/master@{#303584}

Powered by Google App Engine
This is Rietveld 408576698