Issue 722743002: Remove dynamic cast from DocumentPaser interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722743002: Remove dynamic cast from DocumentPaser interface (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel, ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove dynamic cast from DocumentPaser interface This CL cleans up the DocumentParser interface to match what's actually needed by clients. As part of this cleanup, I've removed the asHTMLDocumentParser dynamic cast and just exposed virtual functions for the state folks were accessing via the dynamic cast. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8740ff19e76e7dfda9105827b57cd4bf7e11b95b

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -50 lines)			Patch
M	sky/engine/core/dom/Document.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	5 chunks	+9 lines, -20 lines	0 comments	Download
M	sky/engine/core/dom/DocumentParser.h	View	3 chunks	+14 lines, -12 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLDocumentParser.h	View	2 chunks	+7 lines, -11 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLDocumentParser.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

6 years, 1 month ago (2014-11-12 21:23:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8740ff19e76e7dfda9105827b57cd4bf7e11b95b.