Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: sky/engine/core/html/parser/HTMLDocumentParser.h

Issue 722743002: Remove dynamic cast from DocumentPaser interface (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/DocumentParser.h ('k') | sky/engine/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/parser/HTMLDocumentParser.h
diff --git a/sky/engine/core/html/parser/HTMLDocumentParser.h b/sky/engine/core/html/parser/HTMLDocumentParser.h
index afbf8e4ccabf1c6cfe0bfc63ece6b312ae3ad18f..ba4b4c10a4c3a4f49c2840478b178d9ca31ca74b 100644
--- a/sky/engine/core/html/parser/HTMLDocumentParser.h
+++ b/sky/engine/core/html/parser/HTMLDocumentParser.h
@@ -78,9 +78,13 @@ public:
};
void didReceiveParsedChunkFromBackgroundParser(PassOwnPtr<ParsedChunk>);
- bool isWaitingForScripts() const;
- bool isExecutingScript() const;
- void executeScriptsWaitingForResources();
+ // From DocumentParser:
+ void detach() override final;
+ void prepareToStopParsing() override final;
+ void stopParsing() override final;
+ bool isWaitingForScripts() const override final;
+ bool isExecutingScript() const override final;
+ void executeScriptsWaitingForResources() override final;
UseCounter* useCounter() { return UseCounter::getFrom(contextForParsingSession()); }
@@ -89,14 +93,6 @@ private:
HTMLTreeBuilder* treeBuilder() const { return m_treeBuilder.get(); }
- virtual HTMLDocumentParser* asHTMLDocumentParser() override final { return this; }
-
- // DocumentParser
- virtual void detach() override final;
- virtual bool processingData() const override final;
- virtual void prepareToStopParsing() override final;
- virtual void stopParsing() override final;
-
bool hasInsertionPoint();
void startBackgroundParser();
« no previous file with comments | « sky/engine/core/dom/DocumentParser.h ('k') | sky/engine/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698