[Android] Upstream android lint script and run it on debug builders.

build/android/lint_suppressions.xml

Index: build/android/lint_suppressions.xml
diff --git a/build/android/lint_suppressions.xml b/build/android/lint_suppressions.xml
new file mode 100644
index 0000000000000000000000000000000000000000..6534dc5ccf374cf12923e7f4e14f40ccdd2e077a
--- /dev/null
+++ b/build/android/lint_suppressions.xml
@@ -0,0 +1,102 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lint>
+  <!--
+STOP! It looks like you want to suppress some lint errors:
+- Have you tried identifing the offending patch?
+  Ask the author for a fix and/or revert the patch.
+- It is preferred to add suppressions in the code instead of
+  sweeping it under the rug here. See:
+  http://developer.android.com/tools/debugging/improving-w-lint.html
+
+Still reading?
+- You can edit this file manually to suppress an issue
+  globally if it is not applicable to the project.
+- You can also rebaseline this file by:
+  build/android/lint_suppressions.xml -r
+  If the rebaseline is temporary, please make sure there is a bug
+  filed and assigned to the author of the offending patch.
+-->
+  <issue id="HandlerLeak">
+    <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/LongPressDetector.java"/>
+  </issue>
+  <issue id="UseSparseArrays">
+    <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java"/>
+    <ignore path="android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java"/>
+    <ignore path="android_webview/java/src/org/chromium/android_webview/AwResource.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/WindowAndroid.java"/>
+  </issue>
+  <issue id="SdCardPath">
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java"/>
+  </issue>
+  <issue id="MissingSuperCall">
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java"/>
+    <ignore path="android_webview/java/src/org/chromium/android_webview/AwContents.java"/>
+  </issue>
+  <issue id="Registered" severity="ignore"/>
+  <issue id="ExportedContentProvider">
+    <ignore path="AndroidManifest.xml"/>
+  </issue>
+  <issue id="SetJavaScriptEnabled" severity="ignore"/>
+  <issue id="ViewConstructor" severity="ignore"/>
+  <issue id="NewApi">
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge.java"/>
+    <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/gfx/SurfaceTexturePlatformWrapper.java"/>
+    <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/ResidentService.java"/>
+    <ignore path="chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java"/>
+    <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java"/>
+    <ignore path="chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanBrowserAccessibilityManager.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/LocalizationUtils.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedComponent.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/Clipboard.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java"/>
+    <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/GenericTouchGesture.java"/>
+    <ignore path="out/Debug/android_webview_apk/classes/org/chromium/android_webview/test/AwTestContainerView.class"/>
+    <ignore path="content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java"/>
+    <ignore path="chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/MediaCodecBridge.java"/>
+    <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java"/>
+  </issue>
+  <issue id="AllowBackup">
+    <ignore path="AndroidManifest.xml"/>
+  </issue>
+  <issue id="OldTargetApi">

[newt (away), 2013/11/14 23:39:46]

I think this should be ignored. We are very aware of out TargetApi level, and
this will only cause trouble for whomever rolls the SDK version.

[frankf, 2013/11/15 20:33:30]

No need for this to be global since there's only one manifest.

On 2013/11/14 23:39:46, newt wrote:

+    <ignore path="AndroidManifest.xml"/>
+  </issue>
+  <issue id="DrawAllocation">
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
+  </issue>
+  <issue id="InlinedApi">
+    <ignore path="media/base/android/java/src/org/chromium/media/MediaCodecBridge.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java"/>
+    <ignore path="base/android/java/src/org/chromium/base/MemoryPressureListener.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java"/>
+    <ignore path="net/android/java/src/org/chromium/net/X509Util.java"/>
+    <ignore path="ui/android/java/src/org/chromium/ui/LocalizationUtils.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge.java"/>
+    <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java"/>
+    <ignore path="content/public/android/java/src/org/chromium/content/browser/DeviceUtils.java"/>
+    <ignore path="printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java"/>
+    <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java"/>
+  </issue>
+  <issue id="DefaultLocale" severity="ignore"/>

[newt (away), 2013/11/14 23:39:46]

I think DefaultLocale warnings are probably legitimate in many cases. The first
two cases I checked in downstream code, for example, were both legitimate issues
that should be fixed.

Of course, there are probably a ton of these. Every time we call String.format()
or String.toLowerCase(). :/

[newt (away), 2013/11/15 17:59:24]

Yes, I think we should enable these warnings. We have code that generates
Javascript or other machine readable output, which could break if
String.format() uses, e.g., a comma instead of a decimal point.

[frankf, 2013/11/15 20:33:30]

Done.

On 2013/11/15 17:59:24, newt wrote:

+  <issue id="WrongCall" severity="ignore"/>

[newt (away), 2013/11/14 23:39:46]

WrongCall warnings are probably helpful. why disable them? were there a ton of
them?

[newt (away), 2013/11/15 17:59:24]

Looks like these all happen in tests. I've never seen a bug caused by this, so
I'm OK with enabling or ignoring these warnings.

[frankf, 2013/11/15 20:33:30]

Left it disabled since it seems to produce mostly false positives.

On 2013/11/15 17:59:24, newt wrote:

+  <issue id="MissingVersion">
+    <ignore path="AndroidManifest.xml"/>
+  </issue>
+  <issue id="Recycle">
+    <ignore path="content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java"/>
+  </issue>
+</lint>