build/android/lint_suppressions.xml - Issue 72273003: [Android] Upstream android lint script and run it on debug builders.

Side by Side Diff: build/android/lint_suppressions.xml

Issue 72273003: [Android] Upstream android lint script and run it on debug builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <lint>

	3 <!--

	4 STOP! It looks like you want to suppress some lint errors:

	5 - Have you tried identifing the offending patch?

	6 Ask the author for a fix and/or revert the patch.

	7 - It is preferred to add suppressions in the code instead of

	8 sweeping it under the rug here. See:

	9 http://developer.android.com/tools/debugging/improving-w-lint.html

	10

	11 Still reading?

	12 - You can edit this file manually to suppress an issue

	13 globally if it is not applicable to the project.

	14 - You can also rebaseline this file by:

	15 build/android/lint_suppressions.xml -r

	16 If the rebaseline is temporary, please make sure there is a bug

	17 filed and assigned to the author of the offending patch.

	18 -->

	19 <issue id="HandlerLeak">

	20 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>

	21 <ignore path="content/public/android/java/src/org/chromium/content/browser/t hird_party/GestureDetector.java"/>

	22 <ignore path="content/public/android/java/src/org/chromium/content/browser/L ongPressDetector.java"/>

	23 </issue>

	24 <issue id="UseSparseArrays">

	25 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>

	26 <ignore path="android_webview/java/src/org/chromium/android_webview/AwQuotaM anagerBridge.java"/>

	27 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/>

	28 <ignore path="ui/android/java/src/org/chromium/ui/WindowAndroid.java"/>

	29 </issue>

	30 <issue id="SdCardPath">

	31 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/>

	32 </issue>

	33 <issue id="MissingSuperCall">

	34 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/>

	35 <ignore path="android_webview/java/src/org/chromium/android_webview/AwConten ts.java"/>

	36 </issue>

	37 <issue id="Registered" severity="ignore"/>

	38 <issue id="ExportedContentProvider">

	39 <ignore path="AndroidManifest.xml"/>

	40 </issue>

	41 <issue id="SetJavaScriptEnabled" severity="ignore"/>

	42 <issue id="ViewConstructor" severity="ignore"/>

	43 <issue id="NewApi">

	44 <ignore path="content/public/android/java/src/org/chromium/content/browser/V SyncMonitor.java"/>

	45 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/>

	46 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUt ils.java"/>

	47 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/>

	48 <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.ja va"/>

	49 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/>

	50 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/BrowserAccessibilityManager.java"/>

	51 <ignore path="ui/android/java/src/org/chromium/ui/gfx/SurfaceTexturePlatform Wrapper.java"/>

	52 <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/Re sidentService.java"/>

	53 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/signin/Sig ninManager.java"/>

	54 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/>

	55 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/infobar/An imationHelper.java"/>

	56 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanBrowserAccessibilityManager.java"/>

	57 <ignore path="ui/android/java/src/org/chromium/ui/LocalizationUtils.java"/>

	58 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/>

	59 <ignore path="ui/android/java/src/org/chromium/ui/Clipboard.java"/>

	60 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/>

	61 <ignore path="media/base/android/java/src/org/chromium/media/AudioManagerAnd roid.java"/>

	62 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatfor mImpl.java"/>

	63 <ignore path="content/public/android/java/src/org/chromium/content/browser/G enericTouchGesture.java"/>

	64 <ignore path="out/Debug/android_webview_apk/classes/org/chromium/android_web view/test/AwTestContainerView.class"/>

	65 <ignore path="content/public/android/javatests/src/org/chromium/content/brow ser/ClipboardTest.java"/>

	66 <ignore path="chrome/test/chromedriver/test/webview_shell/java/src/org/chrom ium/chromedriver_webview_shell/Main.java"/>

	67 <ignore path="media/base/android/java/src/org/chromium/media/MediaCodecBridg e.java"/>

	68 <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebCon tentsDelegateAdapter.java"/>

	69 </issue>

	70 <issue id="AllowBackup">

	71 <ignore path="AndroidManifest.xml"/>

	72 </issue>

	73 <issue id="OldTargetApi">
	newt (away) 2013/11/14 23:39:46 I think this should be ignored. We are very aware I think this should be ignored. We are very aware of out TargetApi level, and this will only cause trouble for whomever rolls the SDK version. frankf 2013/11/15 20:33:30 No need for this to be global since there's only o No need for this to be global since there's only one manifest. On 2013/11/14 23:39:46, newt wrote: Show quoted text > I think this should be ignored. We are very aware of out TargetApi level, and > this will only cause trouble for whomever rolls the SDK version.
	74 <ignore path="AndroidManifest.xml"/>

	75 </issue>

	76 <issue id="DrawAllocation">

	77 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>

	78 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/>

	79 </issue>

	80 <issue id="InlinedApi">

	81 <ignore path="media/base/android/java/src/org/chromium/media/MediaCodecBridg e.java"/>

	82 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/>

	83 <ignore path="base/android/java/src/org/chromium/base/MemoryPressureListener .java"/>

	84 <ignore path="media/base/android/java/src/org/chromium/media/AudioManagerAnd roid.java"/>

	85 <ignore path="net/android/java/src/org/chromium/net/X509Util.java"/>

	86 <ignore path="ui/android/java/src/org/chromium/ui/LocalizationUtils.java"/>

	87 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/BrowserAccessibilityManager.java"/>

	88 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/>

	89 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/>

	90 <ignore path="content/public/android/java/src/org/chromium/content/browser/D eviceUtils.java"/>

	91 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/>

	92 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/>

	93 </issue>

	94 <issue id="DefaultLocale" severity="ignore"/>
	newt (away) 2013/11/14 23:39:46 I think DefaultLocale warnings are probably legiti I think DefaultLocale warnings are probably legitimate in many cases. The first two cases I checked in downstream code, for example, were both legitimate issues that should be fixed. Of course, there are probably a ton of these. Every time we call String.format() or String.toLowerCase(). :/ newt (away) 2013/11/15 17:59:24 Yes, I think we should enable these warnings. We h Show quoted text On 2013/11/14 23:39:46, newt wrote: > I think DefaultLocale warnings are probably legitimate in many cases. The first > two cases I checked in downstream code, for example, were both legitimate issues > that should be fixed. > > Of course, there are probably a ton of these. Every time we call String.format() > or String.toLowerCase(). :/ Yes, I think we should enable these warnings. We have code that generates Javascript or other machine readable output, which could break if String.format() uses, e.g., a comma instead of a decimal point. frankf 2013/11/15 20:33:30 Done. On 2013/11/15 17:59:24, newt wrote: Done. On 2013/11/15 17:59:24, newt wrote: Show quoted text > On 2013/11/14 23:39:46, newt wrote: > > I think DefaultLocale warnings are probably legitimate in many cases. The > first > > two cases I checked in downstream code, for example, were both legitimate > issues > > that should be fixed. > > > > Of course, there are probably a ton of these. Every time we call > String.format() > > or String.toLowerCase(). :/ > > Yes, I think we should enable these warnings. We have code that generates > Javascript or other machine readable output, which could break if > String.format() uses, e.g., a comma instead of a decimal point.
	95 <issue id="WrongCall" severity="ignore"/>
	newt (away) 2013/11/14 23:39:46 WrongCall warnings are probably helpful. why disab WrongCall warnings are probably helpful. why disable them? were there a ton of them? newt (away) 2013/11/15 17:59:24 Looks like these all happen in tests. I've never s Show quoted text On 2013/11/14 23:39:46, newt wrote: > WrongCall warnings are probably helpful. why disable them? were there a ton of > them? Looks like these all happen in tests. I've never seen a bug caused by this, so I'm OK with enabling or ignoring these warnings. frankf 2013/11/15 20:33:30 Left it disabled since it seems to produce mostly Left it disabled since it seems to produce mostly false positives. On 2013/11/15 17:59:24, newt wrote: Show quoted text > On 2013/11/14 23:39:46, newt wrote: > > WrongCall warnings are probably helpful. why disable them? were there a ton of > > them? > > Looks like these all happen in tests. I've never seen a bug caused by this, so > I'm OK with enabling or ignoring these warnings.
	96 <issue id="MissingVersion">

	97 <ignore path="AndroidManifest.xml"/>

	98 </issue>

	99 <issue id="Recycle">

	100 <ignore path="content/public/android/javatests/src/org/chromium/content/brow ser/ContentViewGestureHandlerTest.java"/>

	101 </issue>

	102 </lint>

OLD	NEW

« no previous file with comments | « build/android/lint.py ('k') | no next file » | no next file with comments »