chrome/browser/apps/ephemeral_app_launcher.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/apps/app_window_browsertest.cc ('k') | chrome/browser/background/background_mode_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_launcher.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc

index 90f423f494643ebfe19f10c5eb30ebb782c91356..6bbc310358aed290334f19e9ceae722277b06c67 100644

--- a/chrome/browser/apps/ephemeral_app_launcher.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_navigator.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/ui/extensions/extension_enable_flow.h"

#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"

@@ -21,6 +22,7 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/management_policy.h"

+#include "extensions/common/constants.h"

#include "extensions/common/permissions/permissions_data.h"

using content::WebContents;

@@ -276,7 +278,8 @@ void EphemeralAppLauncher::LaunchApp(const Extension* extension) const {

ExtensionRegistry::Get(profile())

->GetExtensionById(extension->id(), ExtensionRegistry::ENABLED));

- AppLaunchParams params(profile(), extension, NEW_FOREGROUND_TAB);

+ AppLaunchParams params(profile(), extension, NEW_FOREGROUND_TAB,

+ extensions::SOURCE_EPHEMERAL);

params.desktop_type =

chrome::GetHostDesktopTypeForNativeWindow(parent_window_);

OpenApplication(params);