chrome/browser/apps/app_window_browsertest.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_window_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/apps/app_browsertest_util.cc ('k') | chrome/browser/apps/ephemeral_app_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_window_browsertest.cc

diff --git a/chrome/browser/apps/app_window_browsertest.cc b/chrome/browser/apps/app_window_browsertest.cc

index dd444d301852eaad49cff1a4be4386e4934b7dc6..76c1f4410a96b56fd685ed5cc96fbdb6e4e7109b 100644

--- a/chrome/browser/apps/app_window_browsertest.cc

+++ b/chrome/browser/apps/app_window_browsertest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/apps/app_browsertest_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "content/public/browser/notification_service.h"

#include "content/public/test/test_utils.h"

@@ -215,10 +216,9 @@ IN_PROC_BROWSER_TEST_F(AppWindowAPITest,

test_data_dir_.AppendASCII("platform_apps").AppendASCII("window_api"));

EXPECT_TRUE(extension);

- OpenApplication(AppLaunchParams(browser()->profile(),

- extension,

- extensions::LAUNCH_CONTAINER_NONE,

- NEW_WINDOW));

+ OpenApplication(AppLaunchParams(browser()->profile(), extension,

+ extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,

+ extensions::SOURCE_UNTRACKED));

ExtensionTestMessageListener geometry_listener("ListenGeometryChange", true);