athena/extensions/chrome/extensions_delegate_impl.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/chrome/extensions_delegate_impl.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/extensions/chrome/extensions_delegate_impl.cc

diff --git a/athena/extensions/chrome/extensions_delegate_impl.cc b/athena/extensions/chrome/extensions_delegate_impl.cc

index 667bc09b4fed1a64e73324b9e54daf0ac03eb53a..1ee5aaef25f9cc26bb990681ca693d389c551bab 100644

--- a/athena/extensions/chrome/extensions_delegate_impl.cc

+++ b/athena/extensions/chrome/extensions_delegate_impl.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

#include "extensions/browser/extension_registry.h"

@@ -58,10 +59,9 @@ class ChromeExtensionsDelegate : public ExtensionsDelegate {

return false;

int event_flags = 0;

- AppLaunchParams params(Profile::FromBrowserContext(context),

- extension,

- event_flags,

- chrome::HOST_DESKTOP_TYPE_ASH);

+ AppLaunchParams params(Profile::FromBrowserContext(context), extension,

+ event_flags, chrome::HOST_DESKTOP_TYPE_ASH,

+ SOURCE_APP_LAUNCHER);

oshima 2014/11/12 18:06:26 nit: one parameter per line.

cylee1 2014/11/12 20:02:07 Tried, but after running "git cl format" and it re

// TODO(oshima): rename HOST_DESTOP_TYPE_ASH to non native desktop.

if (app_id == extensions::kWebStoreAppId) {

« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest.cc » ('j') | no next file with comments »