Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

athena/extensions/chrome/extensions_delegate_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "athena/extensions/public/extensions_delegate.h"
 
 #include "athena/extensions/chrome/athena_chrome_app_window_client.h"
 #include "athena/extensions/chrome/athena_extension_install_ui.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/extensions/app_launch_params.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/extension_urls.h"
 #include "net/base/url_util.h"
 
 namespace athena {
@@ skipping 27 matching lines @@
             app_id, extensions::ExtensionRegistry::EVERYTHING);
     DCHECK(extension);
     if (!extension)
       return false;
 
     // TODO(oshima): Support installation/enabling process.
     if (!extensions::util::IsAppLaunchableWithoutEnabling(app_id, context))
       return false;
 
     int event_flags = 0;
-    AppLaunchParams params(Profile::FromBrowserContext(context),
-                           extension,
-                           event_flags,
-                           chrome::HOST_DESKTOP_TYPE_ASH);
+    AppLaunchParams params(Profile::FromBrowserContext(context), extension,
+                           event_flags, chrome::HOST_DESKTOP_TYPE_ASH,
+                           SOURCE_APP_LAUNCHER);

[oshima, 2014/11/12 18:06:26]

nit: one parameter per line.

[cylee1, 2014/11/12 20:02:07]

Tried, but after running "git cl format" and it re-format like so.

     // TODO(oshima): rename HOST_DESTOP_TYPE_ASH to non native desktop.
 
     if (app_id == extensions::kWebStoreAppId) {
       std::string source_value =
           std::string(extension_urls::kLaunchSourceAppList);
       // Set an override URL to include the source.
       GURL extension_url =
           extensions::AppLaunchInfo::GetFullLaunchURL(extension);
       params.override_url = net::AppendQueryParameter(
           extension_url, extension_urls::kWebstoreSourceField, source_value);
@@ skipping 28 matching lines @@
 
 }  // namespace
 
 // static
 void ExtensionsDelegate::CreateExtensionsDelegate(
     content::BrowserContext* context) {
   new ChromeExtensionsDelegate(context);
 }
 
 }  // namespace athena