Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 722643002: No need to detect change in size when opting for PositionedMovementLayout (Closed)

Created:
6 years, 1 month ago by rhogan
Modified:
6 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

No need to detect change in size when opting for PositionedMovementLayout PositionedMovementLayout determines if it needs to do a full layout so there is no need to second-guess that when parsing the style change. BUG=428050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186335

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -56 lines) Patch
A + LayoutTests/fast/block/positioning/positioned-movement-layout-when-height-changes.html View 5 chunks +5 lines, -11 lines 0 comments Download
A + LayoutTests/fast/block/positioning/positioned-movement-layout-when-height-changes-expected.html View 4 chunks +7 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 chunks +1 line, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pdr.
LGTM. Took me a minute to trace this code but I agree with you that ...
6 years ago (2014-12-01 21:03:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722643002/20001
6 years ago (2014-12-02 20:00:23 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-02 21:09:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186335

Powered by Google App Engine
This is Rietveld 408576698