Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 722643002: No need to detect change in size when opting for PositionedMovementLayout (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 void logicalExtentAfterUpdatingLogicalWidth(const LayoutUnit& logicalTop, Lo gicalExtentComputedValues&); 500 void logicalExtentAfterUpdatingLogicalWidth(const LayoutUnit& logicalTop, Lo gicalExtentComputedValues&);
501 501
502 // Called when a positioned object moves but doesn't necessarily change size . A simplified layout is attempted 502 // Called when a positioned object moves but doesn't necessarily change size . A simplified layout is attempted
503 // that just updates the object's position. If the size does change, the obj ect remains dirty. 503 // that just updates the object's position. If the size does change, the obj ect remains dirty.
504 bool tryLayoutDoingPositionedMovementOnly() 504 bool tryLayoutDoingPositionedMovementOnly()
505 { 505 {
506 LayoutUnit oldWidth = logicalWidth(); 506 LayoutUnit oldWidth = logicalWidth();
507 LogicalExtentComputedValues computedValues; 507 LogicalExtentComputedValues computedValues;
508 logicalExtentAfterUpdatingLogicalWidth(logicalTop(), computedValues); 508 logicalExtentAfterUpdatingLogicalWidth(logicalTop(), computedValues);
509 // If we shrink to fit our width may have changed, so we still need full layout. 509 // If we shrink to fit our width may have changed, so we still need full layout.
510 // FIXME: We check for potential change of width when deciding to set ne edsPositionedMovementLayout.
511 // So either that check or this one is unnecessary, probably the former. crbug.com/428050
512 if (oldWidth != computedValues.m_extent) 510 if (oldWidth != computedValues.m_extent)
513 return false; 511 return false;
514 setLogicalWidth(computedValues.m_extent); 512 setLogicalWidth(computedValues.m_extent);
515 setLogicalLeft(computedValues.m_position); 513 setLogicalLeft(computedValues.m_position);
516 setMarginStart(computedValues.m_margins.m_start); 514 setMarginStart(computedValues.m_margins.m_start);
517 setMarginEnd(computedValues.m_margins.m_end); 515 setMarginEnd(computedValues.m_margins.m_end);
518 updateLogicalHeight(); 516 updateLogicalHeight();
519 return true; 517 return true;
520 } 518 }
521 519
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 if (UNLIKELY(inlineBoxWrapper() != 0)) 813 if (UNLIKELY(inlineBoxWrapper() != 0))
816 deleteLineBoxWrapper(); 814 deleteLineBoxWrapper();
817 } 815 }
818 816
819 ensureRareData().m_inlineBoxWrapper = boxWrapper; 817 ensureRareData().m_inlineBoxWrapper = boxWrapper;
820 } 818 }
821 819
822 } // namespace blink 820 } // namespace blink
823 821
824 #endif // RenderBox_h 822 #endif // RenderBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698