Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 722513003: Enable -Wunused-local-typedef (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
hans, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable -Wunused-local-typedef BUG=321833 TBR=brettw Committed: https://crrev.com/4970b5813302934cfc3df8ccd0b8647a912884a1 Cr-Commit-Position: refs/heads/master@{#303892}

Patch Set 1 #

Patch Set 2 : gn #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : gnnn #

Patch Set 6 : libpho #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -22 lines) Patch
M base/memory/scoped_ptr_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 2 3 4 5 6 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M sdch/BUILD.gn View 1 2 3 4 5 6 2 chunks +18 lines, -4 lines 0 comments Download
M sdch/sdch.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/libphonenumber/libphonenumber.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
brettw: BUILD.gn files hans: rest
6 years, 1 month ago (2014-11-12 17:41:26 UTC) #2
hans
lgtm
6 years, 1 month ago (2014-11-12 17:45:40 UTC) #3
Nico
brettw, Ima tbr the gn bits, since they're fairly small and I want to discover ...
6 years, 1 month ago (2014-11-12 19:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722513003/120001
6 years, 1 month ago (2014-11-12 19:07:53 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 1 month ago (2014-11-12 20:53:40 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 20:54:36 UTC) #8
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4970b5813302934cfc3df8ccd0b8647a912884a1
Cr-Commit-Position: refs/heads/master@{#303892}

Powered by Google App Engine
This is Rietveld 408576698