Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 722513003: Enable -Wunused-local-typedef (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdch/sdch.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index 22d13475be5fc88f86d5a4ddf3901e55834c4771..2f04ff53735d758a6775553294a02a384380a09a 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -92,6 +92,16 @@ test("libphonenumber_unittests") {
include_dirs = [ "src/test" ]
+ # gn orders flags on a target before flags from configs. The default config
+ # adds -Wall, and these flags have to be after -Wall -- so they need to come
+ # from a config and can't be on the target directly.
+ config("libphonenumber_unittests_warnings") {
+ if (is_clang) {
+ cflags = [ "-Wno-unused-local-typedef" ]
+ }
+ }
+ configs += [ ":libphonenumber_unittests_warnings" ]
+
deps = [
":libphonenumber_without_metadata",
"//base",
« no previous file with comments | « sdch/sdch.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698