Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: content/common/permission_service.mojom

Issue 722153003: Implement basic mojo Permission service and use it for Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/permission_service.mojom
diff --git a/content/common/permission_service.mojom b/content/common/permission_service.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..1f33c058e606ae4fa562922f5d58ef7b858a496b
--- /dev/null
+++ b/content/common/permission_service.mojom
@@ -0,0 +1,36 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module content;
+
+enum PermissionStatus {
+ GRANTED,
+ DENIED,
+ ASK
+};
+
+enum PermissionName {
+ GEOLOCATION,
+};
+
+// The Permission service provides permission handling capabilities by exposing
+// methods to check, request, and revoke permissions. It also allows a client to
+// start listening to permission changes.
+interface PermissionService {
+ QueryPermission(PermissionName permission, string origin)
+ => (PermissionStatus status);
+ RequestPermission(PermissionName permission, string origin)
blundell 2014/11/14 14:42:00 You might want to specify that this returns the cu
mlamouri (slow - plz ping) 2014/11/14 16:14:45 I would consider this an implementation detail. As
+ => (PermissionStatus status);
+// RevokePermission(PermissionName permission, string origin)
qsr 2014/11/14 14:28:18 Can you delete the lines instead of using comments
blundell 2014/11/14 14:42:00 I would kill all of this rather than land commente
mlamouri (slow - plz ping) 2014/11/14 16:14:45 Done.
+// => (PermissionStatus status);
+
+// StartObserving(PermissionName permission, string origin);
+// StopObserving(PermissionName permission, string origin);
+};
+
+// interface PermissionServiceClient {
+// OnPermissionChange(PermissionName permission,
+// string origin,
+// PermissionStatus status);
+// };

Powered by Google App Engine
This is Rietveld 408576698