Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Side by Side Diff: content/common/permission_service.mojom

Issue 722153003: Implement basic mojo Permission service and use it for Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module content;
6
7 enum PermissionStatus {
8 GRANTED,
9 DENIED,
10 ASK
11 };
12
13 enum PermissionName {
14 GEOLOCATION,
15 };
16
17 // The Permission service provides permission handling capabilities by exposing
18 // methods to check, request, and revoke permissions. It also allows a client to
19 // start listening to permission changes.
20 interface PermissionService {
21 QueryPermission(PermissionName permission, string origin)
22 => (PermissionStatus status);
23 RequestPermission(PermissionName permission, string origin)
blundell 2014/11/14 14:42:00 You might want to specify that this returns the cu
mlamouri (slow - plz ping) 2014/11/14 16:14:45 I would consider this an implementation detail. As
24 => (PermissionStatus status);
25 // RevokePermission(PermissionName permission, string origin)
qsr 2014/11/14 14:28:18 Can you delete the lines instead of using comments
blundell 2014/11/14 14:42:00 I would kill all of this rather than land commente
mlamouri (slow - plz ping) 2014/11/14 16:14:45 Done.
26 // => (PermissionStatus status);
27
28 // StartObserving(PermissionName permission, string origin);
29 // StopObserving(PermissionName permission, string origin);
30 };
31
32 // interface PermissionServiceClient {
33 // OnPermissionChange(PermissionName permission,
34 // string origin,
35 // PermissionStatus status);
36 // };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698