Navigation transitions (web to native app): Get names and rects of transition elements (Step 4)

public/web/WebTransitionElementData.h

Index: public/web/WebTransitionElementData.h
diff --git a/public/web/WebTransitionElementData.h b/public/web/WebTransitionElementData.h
index 3a8537f47151037bf36360f79a1b203489f5d3c4..b6aa388f03f36a0f34f91d437a5bc0a0402ddb85 100644
--- a/public/web/WebTransitionElementData.h
+++ b/public/web/WebTransitionElementData.h
@@ -31,6 +31,9 @@
 #ifndef WebTransitionElementData_h
 #define WebTransitionElementData_h
 
+#if INSIDE_BLINK
+#include "core/dom/Document.h"

[Nate Chapin, 2014/11/13 19:27:30]

Including core/ from public/web/ is a layering violation. The
WebTransitionElement constructor should probably just take a WebString and a
WebRect.

[Zhen Wang, 2014/11/13 21:56:03]

I see. Assigning the values in FrameLoaderClientImpl.cpp now.

+#endif
 #include "../platform/WebRect.h"
 #include "../platform/WebString.h"
 #include "../platform/WebVector.h"
@@ -40,6 +43,16 @@ namespace blink {
 struct WebTransitionElement {
     WebString id;
     WebRect rect;
+
+    WebTransitionElement()
+        : id(WebString())
+        , rect(WebRect()) { }
+
+#if INSIDE_BLINK
+    WebTransitionElement(const Document::TransitionElement& element)
+        : id(element.id)
+        , rect(element.rect) { }
+#endif
 };
 
 struct WebTransitionElementData {