Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 721783003: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/da5e8127537b0117bda88f8d7eb9cf7e27f8771d Cr-Commit-Position: refs/heads/master@{#303925}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 5 chunks +5 lines, -5 lines 1 comment Download
M chrome/service/service_utility_process_host.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
6 years, 1 month ago (2014-11-12 23:00:37 UTC) #2
dcheng
https://codereview.chromium.org/721783003/diff/1/chrome/service/cloud_print/print_system_win.cc File chrome/service/cloud_print/print_system_win.cc (right): https://codereview.chromium.org/721783003/diff/1/chrome/service/cloud_print/print_system_win.cc#newcode394 chrome/service/cloud_print/print_system_win.cc:394: if (job_ptr_ && job_ptr_->get()) { This seems pretty sketchy. ...
6 years, 1 month ago (2014-11-12 23:01:32 UTC) #3
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-12 23:02:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721783003/1
6 years, 1 month ago (2014-11-12 23:04:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 23:56:51 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 23:58:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da5e8127537b0117bda88f8d7eb9cf7e27f8771d
Cr-Commit-Position: refs/heads/master@{#303925}

Powered by Google App Engine
This is Rietveld 408576698