Remove implicit conversions from scoped_refptr to T* in chrome/

chrome/service/cloud_print/print_system_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/cloud_print/print_system.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 342 matching lines @@
 
     virtual void OnChildDied() override { PrintJobDone(false); }
 
     // base::win::ObjectWatcher::Delegate implementation.
     virtual void OnObjectSignaled(HANDLE object) override {
       // TODO(vadimt): Remove ScopedTracker below once crbug.com/418183 is
       // fixed.
       tracked_objects::ScopedTracker tracking_profile(
           FROM_HERE_WITH_EXPLICIT_FUNCTION("Core_OnObjectSignaled"));
 
-      DCHECK(xps_print_job_);
+      DCHECK(xps_print_job_.get());
       DCHECK(object == job_progress_event_.Get());
       ResetEvent(job_progress_event_.Get());
       if (!delegate_)
         return;
       XPS_JOB_STATUS job_status = {0};
       xps_print_job_->GetJobStatus(&job_status);
       if ((job_status.completion == XPS_JOB_CANCELLED) ||
           (job_status.completion == XPS_JOB_FAILED)) {
         delegate_->OnJobSpoolFailed();
       } else if (job_status.jobId ||
@@ skipping 10 matching lines @@
 
    private:
     // Helper class to allow PrintXPSDocument() to have multiple exits.
     class PrintJobCanceler {
      public:
       explicit PrintJobCanceler(
           base::win::ScopedComPtr<IXpsPrintJob>* job_ptr)
           : job_ptr_(job_ptr) {
       }
       ~PrintJobCanceler() {
-        if (job_ptr_ && *job_ptr_) {
+        if (job_ptr_ && job_ptr_->get()) {

[dcheng, 2014/11/12 23:01:32]

This seems pretty sketchy. I have a TODO to come back and fix this.

           (*job_ptr_)->Cancel();
           job_ptr_->Release();
         }
       }
 
       void reset() { job_ptr_ = NULL; }
 
      private:
       base::win::ScopedComPtr<IXpsPrintJob>* job_ptr_;
 
@@ skipping 31 matching lines @@
 
     // Called on the service process IO thread.
     void RenderPDFPagesInSandbox(const base::FilePath& pdf_path,
                                  const gfx::Rect& render_area,
                                  int render_dpi,
                                  const scoped_refptr<base::MessageLoopProxy>&
                                      client_message_loop_proxy) {
       DCHECK(g_service_process->io_thread()->message_loop_proxy()->
           BelongsToCurrentThread());
       scoped_ptr<ServiceUtilityProcessHost> utility_host(
-          new ServiceUtilityProcessHost(this, client_message_loop_proxy));
+          new ServiceUtilityProcessHost(this, client_message_loop_proxy.get()));
       // TODO(gene): For now we disabling autorotation for CloudPrinting.
       // Landscape/Portrait setting is passed in the print ticket and
       // server is generating portrait PDF always.
       // We should enable autorotation once server will be able to generate
       // PDF that matches paper size and orientation.
       if (utility_host->StartRenderPDFPagesToMetafile(
               pdf_path,
               printing::PdfRenderSettings(render_area, render_dpi, false))) {
         // The object will self-destruct when the child process dies.
         utility_host.release();
@@ skipping 125 matching lines @@
                    this, base::MessageLoopProxy::current()));
   }
 
  private:
   void GetPrinterCapsAndDefaultsImpl(
       const scoped_refptr<base::MessageLoopProxy>&
           client_message_loop_proxy) {
     DCHECK(g_service_process->io_thread()->message_loop_proxy()->
         BelongsToCurrentThread());
     scoped_ptr<ServiceUtilityProcessHost> utility_host(
-        new ServiceUtilityProcessHost(this, client_message_loop_proxy));
+        new ServiceUtilityProcessHost(this, client_message_loop_proxy.get()));
     if (utility_host->StartGetPrinterCapsAndDefaults(printer_name_)) {
       // The object will self-destruct when the child process dies.
       utility_host.release();
     } else {
       client_message_loop_proxy->PostTask(
           FROM_HERE,
           base::Bind(&PrinterCapsHandler::OnChildDied, this));
     }
   }
 
   void GetPrinterSemanticCapsAndDefaultsImpl(
       const scoped_refptr<base::MessageLoopProxy>&
           client_message_loop_proxy) {
     DCHECK(g_service_process->io_thread()->message_loop_proxy()->
         BelongsToCurrentThread());
     scoped_ptr<ServiceUtilityProcessHost> utility_host(
-        new ServiceUtilityProcessHost(this, client_message_loop_proxy));
+        new ServiceUtilityProcessHost(this, client_message_loop_proxy.get()));
     if (utility_host->StartGetPrinterSemanticCapsAndDefaults(printer_name_)) {
       // The object will self-destruct when the child process dies.
       utility_host.release();
     } else {
       client_message_loop_proxy->PostTask(
           FROM_HERE,
           base::Bind(&PrinterCapsHandler::OnChildDied, this));
     }
   }
 
@@ skipping 210 matching lines @@
 }
 
 }  // namespace
 
 scoped_refptr<PrintSystem> PrintSystem::CreateInstance(
     const base::DictionaryValue* print_system_settings) {
   return new PrintSystemWin;
 }
 
 }  // namespace cloud_print